a8n: Only create new Changesets if they can be synced

Review changes
Download
Patches
Plain diff

Merged a8n: Only create new Changesets if they can be synced

a8n/create-sync-changesets-tx into master

Overview 1
Commits 1
Pipelines 0
Changes 1

Merged a8n: Only create new Changesets if they can be synced

Administratorrequested to merge

a8n/create-sync-changesets-tx into master Nov 14, 2019

Overview 1
Commits 1
Pipelines 0
Changes 1

Created by: mrnugget

This fixes #6535 by extending the transaction to also include the syncing of the to-be-created changesets.

With that, the transaction rolls back and doesn't create potentially invalid changesets in case one of them cannot be synced.

That is much better than adding invalid state to the database which then leads to the changesets syncer failing to sync changesets every time.

Test plan:

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

None

Select labels

Manage project labels

Milestone

3.10

3.10 (expired)

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.