Skip to content
Snippets Groups Projects

a8n: Only create new Changesets if they can be synced

Merged Administrator requested to merge a8n/create-sync-changesets-tx into master

Created by: mrnugget

This fixes #6535 by extending the transaction to also include the syncing of the to-be-created changesets.

With that, the transaction rolls back and doesn't create potentially invalid changesets in case one of them cannot be synced.

That is much better than adding invalid state to the database which then leads to the changesets syncer failing to sync changesets every time.

Test plan:

Merge request reports

Merged by avatar (Jul 8, 2025 2:43am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: codecov[bot]

    Codecov Report

    Merging #6596 into master will decrease coverage by <.01%. The diff coverage is 100%.

    @@            Coverage Diff             @@
    ##           master    #6596      +/-   ##
    ==========================================
    - Coverage   39.19%   39.19%   -0.01%     
    ==========================================
      Files        1215     1215              
      Lines       62346    62345       -1     
      Branches     5935     5935              
    ==========================================
    - Hits        24436    24435       -1     
      Misses      35672    35672              
      Partials     2238     2238
    Impacted Files Coverage Δ
    enterprise/pkg/a8n/resolvers/resolver.go 38.61% <100%> (-0.25%) :arrow_down:
Please register or sign in to reply
Loading