Skip to content
Snippets Groups Projects

authz: Fix Postgres row deadlock

Merged authz: Fix Postgres row deadlock
core/bitbucket-server-authz-fixes into master
Merged Administrator requested to merge core/bitbucket-server-authz-fixes into master

Merge request reports

Merged by avatar (Jun 19, 2025 3:01pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
    Administrator @root
    Author Owner

    Created by: beyang

    Review context (from Slack):

    beyang  any worries about how now the critical zone (transaction zone) is now smaller that it was before (e.g., it does not include the `load` invocation)?
[1m]
tomas  @beyang: It's OK, because we explicitly use "FOR SHARE" (a read lock) in the first load.

[1m]
beyang  i guess it's okay because it preserves before-after atomicity?
[1m]
tomas  Which blocks even outside of a tx
[1m]
beyang  ah got it
[<1m]
tomas  When the row has been locked with FOR UPDATE
Please register or sign in to reply