Something went wrong on our end. Please try again.

batches: Fix multiple tabs racing for URL query state

Review changes
Download
Patches
Plain diff

Merged batches: Fix multiple tabs racing for URL query state

es/no-race-batches-tabs into main

Overview 4
Commits 1
Pipelines 0
Changes 1

Merged batches: Fix multiple tabs racing for URL query state

Administratorrequested to merge

es/no-race-batches-tabs into main Aug 25, 2022

Overview 4
Commits 1
Pipelines 0
Changes 1

Created by: eseliger

After switching back to wildcard tabs, it was forgotten that before those components would not render at the same time. https://github.com/sourcegraph/sourcegraph/pull/40110 migrated to using the wildcard components directly, but forgot to port over the lazy parameter: https://github.com/sourcegraph/sourcegraph/pull/40110/files#diff-733709eadc832fc5f74d1eb476d37c6ae449569239cc0b8653f550cac409d1d1L127

I think this doesn't affect the other stuff that you wanted to address in that PR, correct @courier-new? At least I don't see why we couldn't use lazy with that new tabbing approach.

This missing parameter causes two issues:

Going to the bulp operations tab doesn't reload so it's unclear where the bulk operation went (noticed that while debugging)
The Bulk operations, Executions and Changesets tabs will all three race for the visible (and other, likely) URL query param and keep updating it, leading to an infinite loop of updates, freezing up the page.

Closes https://github.com/sourcegraph/customer/issues/1262