Skip to content
Snippets Groups Projects

batches: Fix multiple tabs racing for URL query state

Created by: eseliger

After switching back to wildcard tabs, it was forgotten that before those components would not render at the same time. https://github.com/sourcegraph/sourcegraph/pull/40110 migrated to using the wildcard components directly, but forgot to port over the lazy parameter: https://github.com/sourcegraph/sourcegraph/pull/40110/files#diff-733709eadc832fc5f74d1eb476d37c6ae449569239cc0b8653f550cac409d1d1L127

I think this doesn't affect the other stuff that you wanted to address in that PR, correct @courier-new? At least I don't see why we couldn't use lazy with that new tabbing approach.

This missing parameter causes two issues:

  • Going to the bulp operations tab doesn't reload so it's unclear where the bulk operation went (noticed that while debugging)
  • The Bulk operations, Executions and Changesets tabs will all three race for the visible (and other, likely) URL query param and keep updating it, leading to an infinite loop of updates, freezing up the page.

Closes https://github.com/sourcegraph/customer/issues/1262

Test plan

Verified that the scenario described in https://github.com/sourcegraph/customer/issues/1262 doesn't happen anymore with this change.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: Piszmog

    Review: Approved

    Just curious, would an e2e test or something should have caught this - if possible?

  • Created by: LawnGnome

    Review: Approved

    Had to dig into the Wildcard implementation a bit to verify that this actually does what we want, but seems good to me.

  • Created by: courier-new

    Review: Approved

    Thanks so much, Erik! This is exactly why I asked for another set of eyes on that previous refactor... :see_no_evil: Guess I should have asked more aggressively, heh. This shouldn't affect that bug, no! :raised_hands:

  • Merged by: eseliger at 2022-08-25 18:15:02 UTC

Please register or sign in to reply
Loading