Rewrite Connection tests for aborting requests with observable emission

Review changes
Download
Patches
Plain diff

Merged Rewrite Connection tests for aborting requests with observable emission

rewrite-connection-tests into master

Overview 0
Commits 2
Pipelines 0
Changes 2

Merged Rewrite Connection tests for aborting requests with observable emission

Administratorrequested to merge

rewrite-connection-tests into master Jan 10, 2019

Overview 0
Commits 2
Pipelines 0
Changes 2

Created by: lguychard

Related issue: #1190

Simplifies Connection unit test re: aborting requests with observable emission, as per @felixfbecker's comment (thanks!)

@felixfbecker's suggested test failed consistently, because it subscribed to observeRequest() and unsubscribed from the returned Observable in the same tick, while Connection processes messages on the next tick, except in the special case of aborting requests that have not yet been handled.

Fixed the suggested test to call unsubscribe() on the next tick, and added another test for synchronously aborting requests that have not yet been handled.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.