Skip to content
Snippets Groups Projects

Rewrite Connection tests for aborting requests with observable emission

Created by: lguychard

Related issue: #1190

Simplifies Connection unit test re: aborting requests with observable emission, as per @felixfbecker's comment (thanks!)

@felixfbecker's suggested test failed consistently, because it subscribed to observeRequest() and unsubscribed from the returned Observable in the same tick, while Connection processes messages on the next tick, except in the special case of aborting requests that have not yet been handled.

Fixed the suggested test to call unsubscribe() on the next tick, and added another test for synchronously aborting requests that have not yet been handled.

Merge request reports

Approval is optional

Merged by avatar (Sep 18, 2025 11:21pm UTC)

Merge details

  • Changes merged into master with 1e61ee68.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading