search pagination: add more tests & fix bugs (!6281) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge sg/pagination-testing into master Oct 31, 2019

Created by: slimsag

After this PR, all of the complex logic in the search pagination API (planning and slicing) is covered by tests extensively. The addition of the tests in this PR caught one off-by-one issue #6286 (closed) which is also fixed by this PR.

Fixes #5999 (closed) Fixes #6286 (closed) Fixes #6287 (closed)

search pagination: add more tests & fix bugs

Merge request reports