Skip to content

Don't swallow errors in updateSettings

Warren Gifford requested to merge update-settings-error into master

Created by: lguychard

Fixes #5887 (closed)

https://github.com/sourcegraph/sourcegraph/pull/2189 had added logic to retry updating the settings when a "version mismatch" error" was thrown. Unfortunately, other errors (like "Invalid JSON") were caught, but never rethrown.

Merge request reports