Don't swallow errors in updateSettings (!5912) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge update-settings-error into master Oct 08, 2019

Created by: lguychard

https://github.com/sourcegraph/sourcegraph/pull/2189 had added logic to retry updating the settings when a "version mismatch" error" was thrown. Unfortunately, other errors (like "Invalid JSON") were caught, but never rethrown.

Don't swallow errors in updateSettings

Merge request reports