Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!40599

Fix external account deletion through graphQL if no GitHub App accounts exist

Review changes
Download
Patches
Plain diff

Merged Fix external account deletion through graphQL if no GitHub App accounts exist

pjlast/github-app-delete-fix into main

Overview 2
Commits 1
Pipelines 0
Changes 2

Merged Fix external account deletion through graphQL if no GitHub App accounts exist

Warren Giffordrequested to merge

pjlast/github-app-delete-fix into main Aug 19, 2022

Overview 2
Commits 1
Pipelines 0
Changes 2

Created by: pjlast

When a GitHub external account is deleted, but there are no corresponding GitHub App external accounts, the account list is empty, which causes a SQL error.

What this means is that you're unable to delete your normal GitHub external accounts.

This fixes that.

Test plan

Added test confirming the bug, then fixed it.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

2

cla-signed team/iam

2

cla-signed team/iam

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

Participants

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading