Reorder components to move token/filter inside left pane

Review changes
Download
Patches
Plain diff

Merged Reorder components to move token/filter inside left pane

mrn/second-polish-round into main

Overview 1
Commits 5
Pipelines 0
Changes 2

Merged Warren Gifford requested to merge mrn/second-polish-round into main 3 years ago

Overview 1
Commits 5
Pipelines 0
Changes 2

Created by: mrnugget

This is another step towards https://github.com/sourcegraph/sourcegraph/issues/34201.

This PR

reorders the components so that the token and the filter row are inside the left pane
it also fixes the appearance of the loading spinner, so it now has a stable position next to token
fixes some word-wrapping inside the results

Screenshot of before/after

Video

This also shows the loading spinner and the filter and that they're sticky

https://user-images.githubusercontent.com/1185253/164710123-a55ec7d3-d4e2-400b-adba-2d745897637e.mp4

Test plan

Tested this locally (see video)

App preview:

Web
Storybook

Check out the client app preview documentation to learn more.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed ref-panel

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.