Skip to content

Reorder components to move token/filter inside left pane

Warren Gifford requested to merge mrn/second-polish-round into main

Created by: mrnugget

This is another step towards https://github.com/sourcegraph/sourcegraph/issues/34201.

This PR

  • reorders the components so that the token and the filter row are inside the left pane
  • it also fixes the appearance of the loading spinner, so it now has a stable position next to token
  • fixes some word-wrapping inside the results

Screenshot of before/after

screenshot_2022-04-22_13 56 31@2x

Video

This also shows the loading spinner and the filter and that they're sticky

https://user-images.githubusercontent.com/1185253/164710123-a55ec7d3-d4e2-400b-adba-2d745897637e.mp4

Test plan

  • Tested this locally (see video)

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading