Skip to content

Remove getOverlayMount() and getGlobalDebugMount()

Warren Gifford requested to merge rm-get-overlay-mount into master

Created by: felixfbecker

Fixes #3228 (closed).

Only GitHub used this, but shouldn't, see #3228 (closed). After removing, they always append to document.body, so there is not reason to have them configurable or subscribe to the mutations (which has a perf impact). It's safe to assume document.body never gets removed from any code host DOM.

Test Plan

Code Hosts
  • GitHub
  • GitHub Enterprise
  • Refined GitHub
  • Phabricator
  • Phabricator integration
  • Bitbucket
  • Gitlab
Browsers
  • Chrome
  • Firefox

Merge request reports