Skip to content

Add helm as a supported deploy_type parameter

Warren Gifford requested to merge caug/track-helm-deployment-type into main

Created by: caugustus-sourcegraph

Update the supported DeployTypes to include Helm. From a code perspective it should be treated the same as Kubernetes, but tracked as a separate item in ping data.

This will allow us to monitor the adoption of Helm by setting the DEPLOY_TYPE env var in the helm chart (#32204 (closed)).

Concerns

There is an argument to be made that Helm is more of a deployment method than a type (environment?), and shouldn't be included in the existing structures. I opted for this approach due to the simplicity but open to objections.

Question: this is not actually changing ping data structures or altering any behavior, just enabling a new value in the existing schema. Is it required to get BizOps approval / submit an RFC / add to the Changelog, or is this considered normal activity?

Test plan

Confirmed that the "helm" deploy type correctly showed up in ping data when set. Checked all references of deploy.Type() and IsDeployTypeKubernetes to make sure that the new type would be treated the same as Kubernetes.

Merge request reports