codeintel: Add fast-path edge unmarshalling

Created by: efritz

For LSIF inputs with integer identifiers, it's much faster to deserialize them directly into structs via json.Unmarshal rather than try to unmarshal them into byte slices and do it by hand (which is what the interner does).

Created by: codecov[bot]

Codecov Report

Merging #12878 into main will decrease coverage by 3.47%. The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main   #12878      +/-   ##
==========================================
- Coverage   51.17%   47.69%   -3.48%     
==========================================
  Files        1447     1245     -202     
  Lines       81170    75228    -5942     
  Branches     6666     4589    -2077     
==========================================
- Hits        41538    35882    -5656     
+ Misses      36061    35833     -228     
+ Partials     3571     3513      -58     

Flag	Coverage Δ
#go	52.65% <84.21%> (+0.01%)
#unit	52.65% <84.21%> (+4.80%)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ntel-worker/internal/correlation/lsif/unmarshal.go	75.86% <84.21%> (+2.06%)
shared/src/util/jsonc.ts	0.00% <0.00%> (-100.00%)
shared/src/search/parser/tokens.ts	0.00% <0.00%> (-100.00%)
shared/src/api/client/api/content.ts	0.00% <0.00%> (-100.00%)
shared/src/api/client/types/hover.ts	0.00% <0.00%> (-100.00%)
shared/src/util/rxjs/asObservable.ts	0.00% <0.00%> (-100.00%)
shared/src/api/client/services/util.ts	0.00% <0.00%> (-100.00%)
shared/src/api/client/mainthread-api.ts	0.00% <0.00%> (-100.00%)
shared/src/api/extension/api/content.ts	0.00% <0.00%> (-100.00%)
shared/src/api/extension/api/context.ts	0.00% <0.00%> (-100.00%)
... and 1169 more

Created by: aidaeology

Please add tests for any unmarshalEdgeFast()

Created by: efritz

It's already covered by existing tests, specifically TestUnmarshalEdgeNumericIDs.

Created by: efritz

@aidaeology I don't feel like this is debt, it's just an enhancement.

Created by: marekweb

Dear all,

This is your release captain speaking.

Branch cut for the 3.19 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you