Skip to content

search: hoist parameters in simple and-expressions

Administrator requested to merge rvt/hoist-and into master

Created by: rvantonder

In #9760 I thought it was sufficient to hoist parameters in or expressions and not and-expressions because simple and-expressions are already reduced due to their tighter grouping to filters. This is true for very simple and expressions that don't concatenate any patterns. But an and expression that concatenates patterns, like:

repo:foo main bar and baz, we interpret as (repo:foo (concat (main bar))) and baz

whereas it would be better to run the heuristic on this form as well, to get

(repo:foo (concat (main bar)) and baz)

Merge request reports

Loading