Skip to content

search: record whether a value was quoted

Administrator requested to merge rvt/quoted-values into master

Created by: rvantonder

The one search mode where we care whether a value is quoted is regexp mode. In this mode, quoted values are interpreted literally. The and/or parser interprets quoted values, but throws away whether it was quoted, and as yet, parameters are untyped. This means that later on, when using the value in regexp mode, we have no idea whether it was quoted or not.

This PR:

  • adds a Quoted field to to Parameter to indicate that it was quoted
  • makes the heuristic search pattern parser (the one that is OK with values like main(,) also first try to parse strings starting with quotes as well-formed delimiter values (before, it would just consume things without caring, which is indeed what we want, except when delimited values are available first.)
  • updates visitor interface
  • updates tests to reflect these decisions

Adding Quoted is not the desired end goal for the Parameter types. It currently pollutes the visitor interface a bit. I will be turning parameter values into better structures with type members later.

Needed up the stack for #9846

Merge request reports