Skip to content

Fix: double quotes not being handled properly in interactive mode

Administrator requested to merge fa/fix-quotes into master

Created by: attfarhan

Fixes https://github.com/sourcegraph/sourcegraph/issues/8418.

Now, we will always wrap the content and message filter inputs in double quotes, and escape any double quotes within the input. As was the case before, we will show the quoted and escaped values when the filter input is non-editable, but we will show the unescaped and unquoted value when it is editable.

This means that for all filters, even those that we previously required users to include quotes (e.g. after:, before:), users should never include quotes to delimit their input, otherwise the quotes will be included in the match and result in an error or unexpected match.

Merge request reports

Loading