Skip to content

search: add content: filter button to interactive mode

Administrator requested to merge rvt/content-pls into master

Created by: rvantonder

Adds a content filter. See this PR more as a proposal (though I think it makes sense to merge). What do we think @attfarhan, @christinaforney? We know users have used the content option from the dropdown, and I feel this should be more discoverable.

Screen Shot 2020-03-13 at 12 38 09 PM

As a follow up (and maybe I'm getting a little ahead of myself): the top search bar is basically redundant once all parts of the query can be specified with buttons/filters. One thing that could make sense down the line is to completely remove the view of the search bar and make the query only editable with the dedicated buttons/fields but then to include a toggle that converts this query to the raw mode when it's clicked (and back to the field/button editing mode when toggled again). I realize that the right hand side toggle already does this to some extent, which is great. And that's why I'd be in favor of removing the raw input search bar completely when in interactive mode. It would also be much more convenient for it to just be a toggle, rather than a dropdown (the advanced search doesn't offer much additionally, and worse, it doesn't preserve my query, I feel this option on the dropdown can go away).

Merge request reports

Loading