Improve filter identification, and don't parse invalid filters in interactive mode
Created by: attfarhan
This PR improves identifying text filters in interactive mode. Previously, we didn't check whether a parsed filter was actually valid, we only checked that it was not a finite filter. Now, we check to make sure the filter is valid in isTextFilter
, so that when we parse filters in interactive mode, invalid filters will not appear in the selected filters bar.
This PR also properly identifies aliases. Previously, the shorthand f:
and r:
filters didn't work. Now, since we're ensuring the filter is validated using the aliases list in the parser, we won't miss out on any aliases. Also added -r
and -f
as identified negated filters.