Skip to content

search: migrate structural search logic to own file

Administrator requested to merge rvt/indexed-structural-search-own-file into master

Created by: rvantonder

I need to change how structural search interacts with indexed/zoekt search and it is becoming very tricky to work with the code in zoekt.go. After a lot of deliberation, I'm moving all structural search logic and interaction with zoekt to it's own file. This PR is a scaffolding change, there is no change in functionality. Please go through the commits to have an easy time. There are only two overarching changes:

  • move currently live code in zoekt.go into it's own file search_structural.go
  • wholesale duplicate the zoekt code that structural search uses and put it in search_structural.go. This is dead code.
    • simplify and rename the zoekt code that structural search uses. This is still dead code.

No tests, no live functionality changes. I will use the dead code in a follow up PR with the changes that I actually want to make.

Merge request reports