Skip to content

search: structural search regex converter should match multiple lines

Administrator requested to merge rvt/structural-search-better-regex-converter into master

Created by: rvantonder

A structural search pattern like {:[_]} implies that a pattern like

{

}

should match (across multiple lines). The regex converter to approximate this was \{.*?\}, but that doesn't match across newlines. So, the regex was underapproximating whether a file could match and missed potential results. This PR changes the conversion from .*? to (.|\s)*?, which can also match across newlines. Not sure what the performance implication is (probably negligible compared to what's already there), but it's more important to not miss things at this point.

No new tests--all the existing tests are updated to reflect this behavioral change. An e2e test could capture the change to results, but I don't view it as essential to this PR.

Merge request reports