Updatecheck: Perform HTTP POST (!7993) · Merge requests · Administrator / sourcegraph

Administrator requested to merge updatecheck-http-post into master Jan 23, 2020

Created by: efritz

With the addition of latency and event count statistics in the ping payload introduced by RFC 100 (and additional upcoming efforts in the automation team), we need to be aware of limits we may hit when packing too much data in the updatecheck query string.

This PR performs an HTTP POST and encodes the query string data as JSON in the request body. The DotCom instance will read the same data via the query string (for GET requests) or from the body (for POST requests).

This PR also ensures that the data serialized into pubsub is valid JSON (without string hacks).

Important: Is there any issue on the product side performing a POST instead of a GET? I may have missed a technical reason that we haven't done this yet (due to transparency of ping requests, firewall rules, etc)? Answers to these questions may void this PR and similar efforts.

Updatecheck: Perform HTTP POST

Merge request reports