Skip to content
Snippets Groups Projects

automation: make regex search replace the default campaign

Created by: rvantonder

Stacked on #7790.

Proposal: make regex the default campaign selection. Why? New users are being introduced to a potentially unfamiliar concept with "campaigns", and definitely a new UI. Regex is a broadly familiar concept, so let's reduce the "newness" exposure and not throw them too far into the deep end. On first exposure users should not initially feel obliged to figure out what comby is in addition to the the campaign workflow/UI.

Merge request reports

Approval is optional

Merged by avatar (Sep 20, 2025 4:59am UTC)

Merge details

  • Changes merged into master with c4736baf.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: rvantonder

    What is the likelyhood that the user will be less successful using regexp compared to comby?

    It depends entirely on what the user wants to do, and I don't have a good intuition around that. What I'm confident about is that the idea of regexp search replace is a familiar concept and provides a segue for other campaigns that may better solve the problem at hand.

  • Created by: christinaforney

    What I'm confident about is that the idea of regexp search replace is a familiar concept and provides a segue for other campaigns that may better solve the problem at hand.

    Agree - let's go for it

  • Created by: codecov[bot]

    Codecov Report

    Merging #7844 into master will increase coverage by <.01%. The diff coverage is 83.33%.

    @@            Coverage Diff             @@
    ##           master    #7844      +/-   ##
    ==========================================
    + Coverage   40.51%   40.51%   +<.01%     
    ==========================================
      Files        1278     1278              
      Lines       66877    66879       +2     
      Branches     6330     6331       +1     
    ==========================================
    + Hits        27096    27098       +2     
      Misses      37310    37310              
      Partials     2471     2471
    Impacted Files Coverage Δ
    ...eb/src/enterprise/campaigns/detail/presentation.ts 100% <ø> (ø) :arrow_up:
    ...ns/detail/form/CampaignPlanSpecificationFields.tsx 87.5% <100%> (+1.13%) :arrow_up:
    enterprise/internal/a8n/campaign_type.go 66.94% <66.66%> (ø) :arrow_up:
  • Created by: rvantonder

    @eseliger just noting we approved the previews in Percy where the dropdown says "Manual" for all campaigns as a reminder for us to look into that later.

Please register or sign in to reply
Loading