LSIF: Do not ensure revision for LSIF result commit resolution
There are no commits yet
Push commits to the source branch or add previously merged commits to review them.
Created by: efritz
This fixes the following scenario:
This operation is too expensive for this particular code path and should simply fail-fast on this edge case of the resolution. After chatting with @keegancsmith and @mrnugget a bit, it seems like it's safe to say that this commit will exist on gitserver if it had existed on gitserver in the past and it also exists on the codehost.
Before this change such conditions cause a multi-second GraphQL query in the API explorer. After this change the results are filtered without a noticeable delay.
Reviwers: This PR simply threads additional variables to expose the NoEnsureCommit
option to the RepositoryResolver.Commit
method. If there is a cleaner solution I had not found, please suggest it!
Push commits to the source branch or add previously merged commits to review them.