Skip to content
Snippets Groups Projects

web: faster SearchResultsList test

Created by: sqs

Previously this test took ~33s to run. Now it takes ~3s (which is about as good as it'll get because it uses the DOM). The reason it took so long was that the resultCount values were needlessly high, and the algorithm appears to be superlinear. The component itself does not appear to have the same performance problem; it only occurs using the test mocks (eg MockVisibilitySensor), probably because after-scroll callbacks are debounced in the browser automatically.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sqs

    @attfarhan I'm going to merge this without review because it is low risk, but let me know if you think the lower constants in the test will make this test less effective.

Please register or sign in to reply
Loading