Skip to content

search: Make search/backend package codecov deterministic

Administrator requested to merge core/determinism into master

Created by: keegancsmith

This bit of code has given false signal too many times on a PR, so this commit ensures we always run the slow and fast path for syncing the set of endpoints with the set of clients.

Previously hese lines of code sometimes run and sometimes do not in our tests: https://sourcegraph.com/github.com/sourcegraph/[email protected]/-/blob/internal/search/backend/horizontal.go#L158-160

We already have a test which quickly has 5 background goroutines running which try to trigger this case, but it wasn't sufficient: https://sourcegraph.com/github.com/sourcegraph/[email protected]/-/blob/internal/search/backend/horizontal_test.go#L38-43

Slack context: https://sourcegraph.slack.com/archives/C07KZF47K/p1574865065040100

Merge request reports