Something went wrong on our end. Please try again.
Created by: mrnugget
This is a rough prototype that implements the first steps of #6852. I built this to illustrate how it can work with the current architecture and, more importantly, what we could change to make it more performant and robust.
Note to reviewers: Look at this by commits. I had to create one huge commit first that exposes types from the graphqlbackend
so I can access search
Shortcomings of this PR:
CampaignJob
s. Possible solution: persist the FileMatches
along with LineMatches
on the CampaignJob
in a jsonb
column.diff
/git diff
once we have "old file content" and "new file content" at hand, or use a library that constructs a diff in memory (so far, none of them were able to produce a working unified diff), or build a library that does this...scopeQuery
, a user-defined string, to our search terms. We're also missing "count:9999" here to make sure we get everything. Possible solutions: something along the lines of RFC 75 that proposes a more structured interface to search.We now need to decide which one of these shortcomings is a blocker.
Update in this comment