Skip to content
Snippets Groups Projects

DRY entrypoints

Merged Administrator requested to merge dry-entrypoints into master

Created by: lguychard

Deduplicates code around extension marker and code intelligence injection in phabricator, integrations & injected script entrypoints.

Also removes comments about extension marker injection being racy in Phabricator and integration entry points: <script> tags with the defer attribute are executed after the document has been parsed, but before DOMContentLoaded fires. Meanwhile, browser extension content scripts are set to run at document_end, after DOMContentLoaded has fired.

Test Plan

  • Browser extension
  • Bitbucket integration
  • Phabricator integration

Merge request reports

Approval is optional
Ready to merge by members who can write to the target branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading