Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!4807

Fix commit ID detection on Bitbucket Server single file code views

Review changes
Download
Patches
Plain diff

Merged Fix commit ID detection on Bitbucket Server single file code views

bitbucket-commit-id-revision-selector into master

Overview 1
Commits 2
Pipelines 0
Changes 3

Merged Fix commit ID detection on Bitbucket Server single file code views

Administratorrequested to merge

bitbucket-commit-id-revision-selector into master Jul 5, 2019

Overview 1
Commits 2
Pipelines 0
Changes 3

Created by: lguychard

Fixes #4593

This unfortunately relies on inspecting the document's context (vs. just the code view context). It was the case before this fix as well (getCommitIDFromLink() uses document.querySelector()). The alternative would be to resolve single file code views to an element that encompasses the repo header:

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

0

None

0

None

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

1

1 Participant

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading