repositoryPathPattern fixes
Created by: lguychard
Rel #4370
The changes introduced here are twofold:
- Always resolve Sourcegraph mapped repo name in browser extension code
- Use the raw repo name when getting the definition URL
Test plan:
-
Test code intelligence hovers on a repo with repositoryPathPattern -
Test in-code-host jump-to-definition on a repo with repositoryPathPattern -
Test intelligence hovers on a repo without repositoryPathPattern -
Test in-code-host jump-to-definition on a repo without repositoryPathPattern -
Test code intelligence, jump-to-definition on the webapp without repositoryPathPattern -
Test code intelligence, jump-to-definition on the with repositoryPathPattern
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #4470 into master will increase coverage by
0.21%
. The diff coverage is58.1%
.@@ Coverage Diff @@ ## master #4470 +/- ## ========================================== + Coverage 47.45% 47.66% +0.21% ========================================== Files 722 724 +2 Lines 43828 43885 +57 Branches 1752 1758 +6 ========================================== + Hits 20797 20917 +120 + Misses 21056 20994 -62 + Partials 1975 1974 -1
Impacted Files Coverage Δ shared/src/util/errors.ts 72.22% <ø> (ø)
shared/src/util/url.ts 89.47% <ø> (ø)
browser/src/libs/phabricator/index.tsx 50% <ø> (ø)
browser/src/libs/phabricator/file_info.ts 32.14% <0%> (+4.01%)
browser/src/libs/phabricator/util.tsx 7.56% <0%> (ø)
browser/src/libs/gitlab/scrape.ts 25.86% <0%> (ø)
browser/src/libs/phabricator/backend.tsx 7.73% <0%> (ø)
browser/src/libs/gitlab/file_info.ts 28% <0%> (ø)
browser/src/libs/bitbucket/context.tsx 8.69% <0%> (ø)
browser/src/libs/code_intelligence/code_views.ts 92.59% <100%> (+11.82%)
... and 24 more
Please register or sign in to reply