Skip to content
Snippets Groups Projects

support PersonLink elements without a separate displayName

Merged Administrator requested to merge support-user-PersonLink into master

Created by: sqs

Low priority

This makes it possible to render a <PersonLink /> when all you have is a GQL.IUser. There is no good reason for requiring a displayName. The only reason it was required was to avoid a case where the component's API implied that you could render it with neither a displayName nor a user. The new component API prevents that.

Merge request reports

Merged by avatar (Jul 5, 2025 6:02pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: codecov[bot]

    Codecov Report

    Merging #4453 into master will increase coverage by <.01%. The diff coverage is 75%.

    @@            Coverage Diff             @@
    ##           master    #4453      +/-   ##
    ==========================================
    + Coverage   47.06%   47.06%   +<.01%     
    ==========================================
      Files         717      718       +1     
      Lines       43432    43439       +7     
      Branches     1741     1744       +3     
    ==========================================
    + Hits        20440    20446       +6     
    - Misses      21065    21066       +1     
      Partials     1927     1927
    Impacted Files Coverage Δ
    web/src/user/PersonLink.tsx 85.71% <75%> (ø)
Please register or sign in to reply
Loading