Code nav: do not tokenize code views on Bitbucket
Created by: chrismwendt
Motivation: some code hosts have already tokenized the code view (e.g. Bitbucket). The tokenization currently prevents text selection from working on Bitbucket https://github.com/sourcegraph/sourcegraph/issues/4051
Implementation: this adds a boolean codeViewsRequireTokenization
to the CodeHost
interface, and passes it to codeintellify.
Depends on https://github.com/sourcegraph/codeintellify/pull/115
Test plan:
- Run Bitbucket locally
- Open a file
- Make sure text selections work
Fixes https://github.com/sourcegraph/sourcegraph/issues/4051
Slack conversation https://sourcegraph.slack.com/archives/CHXHX7XAS/p1559599129008000
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #4412 into master will decrease coverage by
0.06%
. The diff coverage isn/a
.@@ Coverage Diff @@ ## master #4412 +/- ## ========================================== - Coverage 47.09% 47.02% -0.07% ========================================== Files 714 714 Lines 43182 43180 -2 Branches 1741 1741 ========================================== - Hits 20335 20306 -29 - Misses 20939 20972 +33 + Partials 1908 1902 -6
Impacted Files Coverage Δ browser/src/libs/phabricator/code_intelligence.ts 52.85% <ø> (ø)
...r/src/libs/code_intelligence/code_intelligence.tsx 70.31% <ø> (ø)
browser/src/libs/github/code_intelligence.ts 51.26% <ø> (ø)
browser/src/libs/bitbucket/code_intelligence.tsx 67.18% <ø> (ø)
browser/src/libs/gitlab/code_intelligence.ts 71.42% <ø> (ø)
cmd/frontend/graphqlbackend/git_tree_entry.go 2.83% <0%> (-12.92%)
cmd/frontend/graphqlbackend/git_tree.go 52.08% <0%> (-12.51%)
cmd/frontend/graphqlbackend/git_revision.go 0% <0%> (-7.41%)
cmd/frontend/graphqlbackend/git_commit.go 21.01% <0%> (-5.08%)
Please register or sign in to reply