Skip to content
Snippets Groups Projects

No-op extensions controller should mark initial extensions as loaded

Merged Administrator requested to merge ps/noop-extension-loading into main

Created by: philipp-spiess

This was an oversight when I created the no-op extensions controller that was discovered while I fixed tests for #41129.

When the no-op extensions controller is enabled, the actions sidebar is stuck in the loading state because the subscribeable is never updated.

Since there are no extensions to load in this version, we can always mark them as loaded right away.

(cc @olafurpg this is called in a few places not just the extensions action sidebar so if you see something stuck in the loading state again, this might be the cause for it)

Test plan

Extensions sidebar opens again:

Screenshot 2022-09-05 at 11 52 30

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Merged by avatar (May 1, 2025 12:58am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading