Skip to content

Aggregation: Adjust aggregation url params

Administrator requested to merge vk/adjust-aggregation-url-params into main

Created by: vovakulikov

Fixes https://github.com/sourcegraph/sourcegraph/issues/40868

Test plan

  • Make sure that URL has new aggregation values
    • REPO → repo
    • PATH → path
    • AUTHOR → author
    • CAPTURE_GROUP → group
  • Make sure that when you run aggregation in sidebar panel ULR doesn't have any aggregation UI mode specific query param in URL
  • Make sure that when you run aggregatin in the full UI mode URL has expanded= query param

Why expanded has = at the end

WhatWG spec says that query param always should have value (it's basically a key value pair) Since our hook uses URLSearchParams class we have to have a = at the end. We could change this logic and set param manually but working with search strings may be tricky (we can by accident remove something from the URL)

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading