Skip to content

Aggregation UI: Add proper error UI

Administrator requested to merge vk/add-aggregation-zero-state-bg into main

Created by: vovakulikov

Based on https://github.com/sourcegraph/sourcegraph/pull/40943 Part of https://github.com/sourcegraph/sourcegraph/issues/40766

Figma designs

Background

In this PR we added zero state (bars-like) background for search unavailable error. See tables below for different themes and UI modes

NOTE: Error message will be changed and fixed in a separate issue (@chwarwick FYI)

Aggregation UI Theme Standard UI Simple UI
Sidebar UI Light theme Screenshot 2022-08-27 at 12 21 43 Screenshot 2022-08-27 at 12 21 38
Sidebar UI Dark theme Screenshot 2022-08-27 at 12 21 48 Screenshot 2022-08-27 at 12 21 34
Full UI Light theme Screenshot 2022-08-27 at 12 20 09 Screenshot 2022-08-27 at 12 20 15
Full UI Dark theme Screenshot 2022-08-27 at 12 20 03 Screenshot 2022-08-27 at 12 20 21

Test plan

  • Make sure that error state has a proper zero state bars-like background in both themes and both UI modes (and in both Aggregation UI modes sidebar and full uI).
  • @AlicjaSuska can you please take a look at colors of bars for this state? I changed them a little bit because I found that they look nice in design but in the browser they look vague and it makes harder to read the error text.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading