cmd/gitserver/server: Extract arg to conf.Cached into a func for testability

Review changes
Download
Patches
Plain diff

Merged cmd/gitserver/server: Extract arg to conf.Cached into a func for testability

ig/make-tlsexternal-func into main

Overview 9
Commits 6
Pipelines 0
Changes 3

Merged cmd/gitserver/server: Extract arg to conf.Cached into a func for testability

Administratorrequested to merge

ig/make-tlsexternal-func into main Aug 26, 2022

Overview 9
Commits 6
Pipelines 0
Changes 3

Created by: indradhanush

Making this into a function allows us to test the code to guarantee that multiple certificates configured in the config are written into the SSLCAInfo file correctly.

Also we don't need the type hint anymore since the type is now inferred from the return type of the function itself. Which makes the code easier to read.

Change inspiration out of looking into https://github.com/sourcegraph/customer/issues/1136 and https://github.com/sourcegraph/sourcegraph/issues/38128 respectively this week.

Test plan

Added a test case.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.