insights: `seriesCount` field does not fail whole gql query
There are no commits yet
Push commits to the source branch or add previously merged commits to review them.
Created by: leonore
tackles part of #38951
SeriesCount
return value is made nullableerrorPolicy: ’all'
on insightViews
queries in the webappnb. this isn't a catch-all fix, but this creates a blueprint if we are to add more fields to query in the future. I believe that right now SeriesCount
is the only query that can fail in this way
graphql allows to return both data and errors in its response. however:
so if we make a field nullable we'll be able to get both data and errors. however that must still be handled correctly by the client.
The following test plan was ran on both main
and commit c8524fee4662257ab218a7c08873c77dd613754a (parent of this PR which removed seriesCount
and the issue)
Screenshots:
all insights | dashboard | single insight |
---|---|---|
![]() |
![]() |
![]() |
all insights | dashboard | single insight |
---|---|---|
![]() |
![]() |
![]() |
Push commits to the source branch or add previously merged commits to review them.