Skip to content

codemirror blob: First stab at hover cards

Administrator requested to merge fkling/cm-file-popover into fkling/cm-blob-info

Created by: fkling

Depends on #39448

This is a first implementation of hovercards. It only renders content, no actions and it doesn't support "pinning" cards. I tried to approximate the current hovercard as much as possible but my main goal was to get it working, not to make it look identical. I gave the hovercards a bit more "space" but I still don't like how they look like with few content.

I also add support for document highlights because this will also highlight the token underneath the cursor. Unlike the current blob view the token underneath the cursor isn't rendered in a different color (for the time being).

I tested this with precise code intel information, I don't know how well it works for search based information.

There are some issues wrt hovercard positioning and how quickly the cards update, but those can be resolved in future PRs.

Demo:

https://user-images.githubusercontent.com/179026/181229609-6405a05f-7ed1-4c81-a5c1-5ed3b0212410.mp4

Test plan

Manual testing.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading