search ui: follow up search result items improvements
Created by: limitedmage
Follow up to #38785
- Removes hacky
overflow: hidden
properties on the search results page, instead relying on grid'sminmax
to prevent horizontal scrolling. This is necessary so sticky positioning works. - Made the header of search results sticky so it stays at the top of the screen while scrolling
- Made the collapse button of the search results sticky so it stays at the bottom of the screen while scrolling
- Fixed the flash of content when expanding/collapsing search results when the core workflow improvements are enabled
- Also fixed the text color of placeholder line numbers to match the color of loaded line numbers
- Fixed the repo result text color so it matches the other result types when the core workflow improvements are enabled
https://user-images.githubusercontent.com/206864/179296495-8276379e-664f-474b-b3e9-acade164610c.mp4
Test plan
Test manually with feature flag on and off. No changes should occur in visual tests.
App preview:
Check out the client app preview documentation to learn more.