Bug fix: Turn off overflow-x scroll for HoverOverlay
Created by: oleggromov
What's wrong
As per the bug report in Slack, we've got a horizontal scroll in the code intel popover. This is due to positioning the close button with float: right.
Solution
The proper fix perhaps would be to renovate the popover's layout. However, since this is a quick bug fix, I am just applying the easiest possible solution.
We also add a story to capture this new behavior with a close button.
| Before | After |
|---|---|
 |
 |
Test plan
- Open storybook
yarn storybook - Find WebHoverOverlay --> with close button
- Ensure there's no scroll
Then locally,
- Run sourcegraph
sg start web-standalone - Make sure on you mac scrollbars are always shown (Preferences -> General -> Show scroll bars = always)
- Open a file and hover over an identifier
- You should see no scroll
App preview:
Check out the client app preview documentation to learn more.