Skip to content
Snippets Groups Projects

Enable adding overrides for rollout feature flags

Created by: thenamankumar

closes: https://github.com/sourcegraph/sourcegraph/issues/35795

This PR enabled adding org/user overrides for rollout feature flags as well which was earlier restricted to boolean feature flags.

This also performs minor refactoring over the GetUserFlags method in the database store. There are nested loops present which need not be.

CleanShot 2022-06-16 at 13 54 43@2x

Test plan

  1. Visit /site-admin/feature-flags
  2. Create a new rollout feature flag
  3. Add overrides for user id and org id
  4. Use console to verify working of overrides.
  5. Test deleting overrides

Merge request reports

Merged by avatar (Sep 23, 2025 12:29am UTC)

Merge details

  • Changes merged into main with fbfe3771.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading