Skip to content
Snippets Groups Projects

migration/definition: accept named migrations

Merged Administrator requested to merge 06-13-migration/definition_accept_named_migrations into main

Created by: bobheadxi

Implements the first step of https://github.com/sourcegraph/sourcegraph/issues/37244:

modify readDefinitions in internal/database/migration/definition/read.go to ignore anything after the first _ in the Atoi call

Test plan

Unit tests show this works for both existing migrations and migrations that have names in them

go run ./dev sg migration leaves <commit> works

Merge request reports

Approval is optional

Merged by avatar (Jul 25, 2025 1:46am UTC)

Merge details

  • Changes merged into main with 6d16168c.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading