JetBrains: Move title into web view and add loading indicator

Review changes
Download
Patches
Plain diff

Merged JetBrains: Move title into web view and add loading indicator

Overview 10
Commits 6
Pipelines 0
Changes 10

Merged Administrator requested to merge ps/jetbrains-title into main 3 years ago

Overview 10
Commits 6
Pipelines 0
Changes 10

Created by: philipp-spiess

This PR moves the modal title into the web view so that we can add the loading indicator similar to what we explored in the Figma draft:

We worked around the issue of the popover no longer being moveable by rendering the title and icon only in the native popover title component and moving the loading indicator into the status bar.

Test plan

https://user-images.githubusercontent.com/458591/170710940-a563092b-f0f2-4a17-85a7-3ef4ae97a46c.mov

App preview:

Web
Storybook

Check out the client app preview documentation to learn more.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed jetbrains-ide

Select labels

Manage project labels

Milestone

Integrations 10

Integrations 10 (expired)

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.