Something went wrong while fetching comments. Please try again.

Show “Loading” overlay while the browsers loads

Review changes
Download
Patches
Plain diff

Merged Show “Loading” overlay while the browsers loads

dv/jetbrains-prevent-web-view-flickering-on-load into main

Overview 4
Commits 1
Pipelines 0
Changes 6

Merged Administrator requested to merge dv/jetbrains-prevent-web-view-flickering-on-load into main 3 years ago

Overview 4
Commits 1
Pipelines 0
Changes 6

Created by: vdavid

Fixes https://github.com/sourcegraph/sourcegraph/issues/34694

I've fixed it by using a JLayeredPane (suggested by @madppiper)—or actually, a class extended from that one—and “hiding” the browser window by making in 1x1 pixel big while the web page is loading. Once we loaded the config, theme, and initiated a React render, we display the browser.

Might be even better if we waited for the first React render. So there's still room for improvement.

Another thing: I'm a bit confused with the naming "pane" and "panel" and couldn't learn it efficiently, so it might include bad naming in the class and variable names. This is very easy to fix later, however, so I went ahead and created the PR.