JetBrains: Force recreation of JCEF browser on every modal show

Review changes
Download
Patches
Plain diff

Merged JetBrains: Force recreation of JCEF browser on every modal show

ps/jetbrains-mac-jcef-issue-workaround into main

Overview 7
Commits 2
Pipelines 0
Changes 2

Merged Administrator requested to merge ps/jetbrains-mac-jcef-issue-workaround into main 3 years ago

Overview 7
Commits 2
Pipelines 0
Changes 2

Created by: philipp-spiess

This is a workaround for #34773 (closed): On Mac OS, the web view is empty after opening and closing the popover repeatedly.

We work around the issue by forcing a recreation of the JCEF browser window whenever we open the popover.

Note: This fix is only meant to be temporary since it increases the modal opening times drastically and adds noticeable lag.

Test plan

https://user-images.githubusercontent.com/458591/169494988-ffca8a36-821f-4992-ba70-9feaad01a41d.mov

App preview:

Web
Storybook

Check out the client app preview documentation to learn more.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed jetbrains-ide

Select labels

Manage project labels

Milestone

Integrations 9

Integrations 9 (expired)

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.