Skip to content

fix vsce: open local copy and web on windows

Administrator requested to merge bee/vsce-fix into main

Created by: abeatrix

Close https://github.com/sourcegraph/sourcegraph/issues/34788 & https://github.com/sourcegraph/sourcegraph/pull/34389

Issue 34788

The file path we retrieve from the configuration setting was not being parsed correctly in the final uri to open on Web: image image

Solution

Using the VS Code URI File API to parse the file path has resolved the issue. It should now also work with all systems.

Issue 34389

User @ptxmac has reported an issue related to how the access token is sent, and has suggested a fix in his PR that is blocked by build failing. I have merged his fix into this PR

Test plan

Tested manually on both Windows and Mac.

Follow the guide here to set up a testing environment to test this build: https://github.com/sourcegraph/sourcegraph/blob/main/client/vscode/CONTRIBUTING.md#build-and-run

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading