fix: filters do not work on featured extensions
Created by: abeatrix
Closes https://github.com/sourcegraph/sourcegraph/issues/34799, this issue was identified while auditing https://github.com/sourcegraph/sourcegraph/issues/34052
Before
Visit our extension registry page , under All Categories, select the filter at the bottom:
| Filter Enabled | Screenshot | Filtered Result |
|---|---|---|
| All |  |
All extensions are displayed |
| Show enabled extensions |  |
The filtered result does not match the filter that is enabled. Disabled extensions from the Featured section is still showing up. |
| Show disabled extension |  |
The filtered result does not match the filter that is enabled. Enabled extensions from the Featured section is still showing up. |
After
The issue was that the featured section shows up as a standalone even if the filter is enabled. Only display the featured section when the filter is set to all has resolve the issue:
| Filter Enabled | Screenshot | Filtered Result |
|---|---|---|
| All |  |
All extensions are displayed |
| Show enabled extensions |  |
Only enabled extensions are displayed |
| Show disabled extension |  |
Only disabled extensions are displayed |
Test plan
See screenshot above
App preview:
Check out the client app preview documentation to learn more.