Skip to content

Code Insights: Ignore minutes in series data point dateTime field

Administrator requested to merge vk/small-insight-time-differences into main

Created by: vovakulikov

Closes https://github.com/sourcegraph/sourcegraph/issues/30642

In this PR we ignore minutes in the series data points DateTime field. This fixes points grouping in the LineChart logic.

Point from @Joelkw

Arbitrarily, if two points are within 10 minutes of each other, I think we should show the same tooltip (we could do more than 10 minutes as well – the threshold seems the easier part to change than just building this feature).

I think this is actually a great idea but this also will introduce a few perf problems if we have a lot of insights on the frontend. Related comment in the original issue thread https://github.com/sourcegraph/sourcegraph/issues/30642#issuecomment-1116072360

Test plan

  • Make sure that all insights in your account on k8s look fine

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading